Code review comment for lp:~xtoddx/nova/disable_creds

Revision history for this message
termie (termie) wrote :

diffline 33: please put StatusResponse on the next line, indented with the other args.

should we be internationalizing the response in the disable project creds call?

also looks like you'll need a newline before the StatusResponse class def.

Other than that, looking good. Other folks's comments still applicable, though I think tests will need to be in smoketests if you write them.

review: Needs Fixing

« Back to merge proposal