Merge lp:~xred/bzr-website/osx-screenshot into lp:bzr-website

Proposed by Fred McCann
Status: Needs review
Proposed branch: lp:~xred/bzr-website/osx-screenshot
Merge into: lp:bzr-website
Diff against target: 2 lines (+0/-0)
0 files modified
To merge this branch: bzr merge lp:~xred/bzr-website/osx-screenshot
Reviewer Review Type Date Requested Status
Bazaar Developers Pending
Review via email: mp+285266@code.launchpad.net

Description of the change

Updated screen shot for OS X.

To post a comment you must log in.
Revision history for this message
Vincent Ladeuil (vila) wrote :

/me scratches head

I still don't see the 'Status' label above 'Ready' only maybe the last pixels of them >-/

Are you seeing that too or is it just me ? (I tried 3 different software in case one of them was playing tricks on me but may be they all rely on the same library....)

Can we sort it out by discussing on IRC may be ?

Revision history for this message
Fred McCann (xred) wrote :

I tried resizing the window and playing with this - this is what it currently looks like on OS X. The old screenshot in some ways looks better, but on the other hand, the very outdated aqua look and feel gives the impression that the site is rarely updated.

- Fred McCann
<email address hidden>

> On Feb 6, 2016, at 10:59 AM, Vincent Ladeuil <email address hidden> wrote:
>
> /me scratches head
>
> I still don't see the 'Status' label above 'Ready' only maybe the last pixels of them >-/
>
> Are you seeing that too or is it just me ? (I tried 3 different software in case one of them was playing tricks on me but may be they all rely on the same library....)
>
> Can we sort it out by discussing on IRC may be ?
>
> --
> https://code.launchpad.net/~xred/bzr-website/osx-screenshot/+merge/285266
> You are the owner of lp:~xred/bzr-website/osx-screenshot.

Revision history for this message
Vincent Ladeuil (vila) wrote :

Ha, so you do not see the status label either ?

Hmm, and lp is now playing tricks because... oh well, you'll need to re-merge trunk to make lp happy...

Hmm, so the choice is between outdated and bogus, between a rock and a hard place are we ? ;)

Revision history for this message
Fred McCann (xred) wrote :

Yeah. I can see going either way. I don't know anything about QT, but I'm guessing assumptions about the dimensions of OS X window chrome is to blame.

- Fred McCann
<email address hidden>
(862) 204-9006

> On Feb 6, 2016, at 11:12 AM, Vincent Ladeuil <email address hidden> wrote:
>
> Ha, so you do not see the status label either ?
>
> Hmm, and lp is now playing tricks because... oh well, you'll need to re-merge trunk to make lp happy...
>
> Hmm, so the choice is between outdated and bogus, between a rock and a hard place are we ? ;)
>
>
> --
> https://code.launchpad.net/~xred/bzr-website/osx-screenshot/+merge/285266
> You are the owner of lp:~xred/bzr-website/osx-screenshot.

Revision history for this message
Vincent Ladeuil (vila) wrote :

Hmm, please correct me if I'm wrong but this picture doesn't appear on the site

The only references I can find to it are commented out in the sources (en/index.html and templates/en/index.html).

On the other hand there are plenty of other snapshots with the old aqua theme (fom bzr-explorer I'd say), anyway on osx it's qt so it's either qbzr or bzr-explorer.... but then a first step is probably to fix the layout issues first :-/

I tried tracking down that push one but got lost in the qbzr sources and I think the 'Status' part comes from the SubProcessWindowBase in lib/subprocess.py but not being able to test on osx... doesn't help poking around to see what can fix it :-)

    def make_default_status_box(self):
        panel = QtGui.QWidget()
        vbox = QtGui.QVBoxLayout(panel)
        vbox.setContentsMargins(0, 0, 0, 0)
        vbox.addWidget(self.infowidget)
        status_group_box = QtGui.QGroupBox(gettext("Status"))
        status_layout = QtGui.QVBoxLayout(status_group_box)
        status_layout.setContentsMargins(0, 0, 0, 0)
        status_layout.addWidget(self.process_widget)
        vbox.addWidget(status_group_box)
        return panel

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'carousel/dialog-push-macosx.png'
2Binary files carousel/dialog-push-macosx.png 2010-02-17 10:51:00 +0000 and carousel/dialog-push-macosx.png 2016-02-06 15:31:26 +0000 differ

Subscribers

People subscribed via source and target branches