Code review comment for lp:~xnox/unity8/cross-compile

On 13.12.2013 10:54, Dimitri John Ledkov wrote:
> it does make sense to ship pre-generated dbus code in, e.g. release
> tarball, but not in the version control system. And that dbus tool, is
> not that different from all the other dbus implementations - e.g.
> upstream (libdbus), gnome/gio dbus, libnih-dbus, etc. Also as per
> debian policy, generated source code must be re-generated at
> build-time which is applied consistently for all dbus, cython, vala,
> etc. generators.
>
>> >I'm leaning towards that just because it makes sense, that generated
>> >file will barely ever change (as long as the source file doesn't
>> >change). OTOH building against different versions of Qt, in this case,
>> >might yield different results for the generated files...
>> >
> For QA and CI it's a slippery slope to forget regenerating static
> copies. Or not catch that one cannot regenerate it anymore.

Yeah, ok. You convinced me.