Merge lp:~xnox/ubuntu/saucy/initramfs-tools-ubuntu-touch/missing-mkdir into lp:ubuntu/saucy/initramfs-tools-ubuntu-touch

Proposed by Dimitri John Ledkov
Status: Rejected
Rejected by: Dimitri John Ledkov
Proposed branch: lp:~xnox/ubuntu/saucy/initramfs-tools-ubuntu-touch/missing-mkdir
Merge into: lp:ubuntu/saucy/initramfs-tools-ubuntu-touch
Diff against target: 32 lines (+14/-0)
2 files modified
debian/changelog (+7/-0)
scripts/touch (+7/-0)
To merge this branch: bzr merge lp:~xnox/ubuntu/saucy/initramfs-tools-ubuntu-touch/missing-mkdir
Reviewer Review Type Date Requested Status
Loïc Minier Disapprove
Oliver Grawert Pending
Review via email: mp+189789@code.launchpad.net
To post a comment you must log in.
57. By Dimitri John Ledkov

Mount ${rootmnt}/system for the emulator.

Revision history for this message
Loïc Minier (lool) wrote :

After discusion on IRC, let's defer to post-13.10 as it's not enough in itself to get a fully working emulator and this would have to go through mako/maguro testing.

review: Disapprove

Unmerged revisions

57. By Dimitri John Ledkov

Mount ${rootmnt}/system for the emulator.

56. By Dimitri John Ledkov

Create ${rootmnt}/android directory before mounting.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2013-10-03 16:49:11 +0000
+++ debian/changelog 2013-10-08 09:32:24 +0000
@@ -1,3 +1,10 @@
1initramfs-tools-ubuntu-touch (0.57) UNRELEASED; urgency=low
2
3 * Create ${rootmnt}/android directory before mounting.
4 * Mount ${rootmnt}/system for the emulator.
5
6 -- Dmitrijs Ledkovs <dmitrij.ledkov@ubuntu.com> Tue, 08 Oct 2013 10:04:58 +0100
7
1initramfs-tools-ubuntu-touch (0.56) saucy; urgency=low8initramfs-tools-ubuntu-touch (0.56) saucy; urgency=low
29
3 [ Dmitrijs Ledkovs ]10 [ Dmitrijs Ledkovs ]
411
=== modified file 'scripts/touch'
--- scripts/touch 2013-10-03 16:49:11 +0000
+++ scripts/touch 2013-10-08 09:32:24 +0000
@@ -109,7 +109,14 @@
109 [ -z "$device" ] && device="unknown"109 [ -z "$device" ] && device="unknown"
110 echo "initrd: device is $device" >/dev/kmsg || true110 echo "initrd: device is $device" >/dev/kmsg || true
111111
112 # Mount /system for the emulator
113 if [ "$device" = "generic" ]; then
114 mkdir -p ${rootmnt}/system
115 mount /dev/mtdblock0 ${rootmnt}/system
116 fi
117
112 # Mount some tmpfs118 # Mount some tmpfs
119 mkdir -p ${rootmnt}/android
113 mount -o rw,size=4096 -t tmpfs none ${rootmnt}/android120 mount -o rw,size=4096 -t tmpfs none ${rootmnt}/android
114 mount -o rw,nosuid,noexec,relatime,mode=755 -t tmpfs tmpfs ${rootmnt}/run121 mount -o rw,nosuid,noexec,relatime,mode=755 -t tmpfs tmpfs ${rootmnt}/run
115122

Subscribers

People subscribed via source and target branches