Code review comment for lp:~xnox/ubuntu-archive-publishing/migrate-dist-upgrade-to-4k

Revision history for this message
Steve Langasek (vorlon) wrote :

On Fri, Nov 18, 2016 at 02:34:35PM -0000, Dimitri John Ledkov wrote:

> I have no way to check the key preferences. I assume they are sane.
> Removed the extra arg. Hopefully, we will soon transition to 8K keys and
> SHA3.

In fact, the current prefs on the key will *not* do what we want without
this argument:

     Digest: SHA256, SHA1, SHA384, SHA512, SHA224

I wasn't asking you to drop this arg, now the branch is not in a state that
we can merge :) I was asking whether this was the way we want to do this
going forward or if we should fix the digest preferences on the key.

I'm not sure which is the more obvious place for us to enforce this.

« Back to merge proposal