Merge lp:~xnox/ubiquity/lp1632151 into lp:ubiquity

[Dimitri John Ledkov]

[Dimitri John Ledkov (xnox)]

 * When launching "Install Ubuntu" or when present with try or install ubuntu screen, one cannot login on tty2-6.

 * This impacts debugging facilities during installation.

 * It appears that getty.target is not required by ubiquity, therefore gettys on tty2-6 are not spawned, and no users are allowed to login.

[Martin Pitt (pitti)]

review: Needs Fixing

[lp:~xnox/ubiquity/lp1632151]

6495. By Dimitri John Ledkov on 2016-10-11

Fix typpo in the branch

[Dimitri John Ledkov (xnox)]

Inline comments.

[lp:~xnox/ubiquity/lp1632151]

6496. By Dimitri John Ledkov on 2016-10-11

Use older bug number

6497. By Dimitri John Ledkov on 2016-10-11

Also force using tty7, by issuing chvt 7 in the start-ubiquity-dm
script. For some reason, active vt is 1 during ubiquity-dm execution.

[Martin Pitt (pitti)]

I still don't understand how this does not lead to a dependency cycle: ubiquity.service has Before=plymouth-quit-wait.service and getty@.service has "After=plymouth-quit-wait.service" -- i. e. right now we sort ubiquity ← plymouth ← getty. Thus we can't possibly start getty before ubiquity, which is what the new Requires/After= in this MP does.

Can you please check the journal with this patch to check if there are any dependency loops? If you throw plymouth out of the equation then it should work, but I'm not sure if we are ready to give up on that.

review: Needs Information

[Dimitri John Ledkov (xnox)]

I'll check that. My understanding is that normal Ubuntu Desktop and Ubiquity/Installer boots do not need plymouth-quit-wait.service at all, as both lightdm & ubiquity-dm have plymouth integration and stop it if plymouth is running.

The only cases when plymouth-quit-wait is needed I'm guessing is on the server / no display manager setups.

I'm pretty sure we excluded plymouth dependencies dynamically back in the upstart days, by emitting events to by-pass "plymouth-quit-wait".

[Jean-Baptiste Lallement (jibel)]

@xnox, I tried your patch on Bionic Ubuntu Desktop and it indeed creates a dependency cycle that systemd fixes by deleting ubiquity.service according to the log:

Mar 13 10:58:46 ubuntu systemd[1]: plymouth-quit-wait.service: Job ubiquity.service/start deleted to break ordering cycle starting with plymouth-quit-wait.service/start

review: Needs Fixing

[Jean-Baptiste Lallement (jibel)]

And I confirm the patch works if I drop plymouth-quit-wait

[Dimitri John Ledkov (xnox)]

This need adaptation, as these days ubiquity starts on vt1.

And i think ubiquity can simply want getty.target, such that getty's are available on vt2-7, which on vt1 it fights with plymouth-quit-service.

[Jean-Baptiste Lallement (jibel)]

Fixed with https://code.launchpad.net/~vorlon/ubiquity/dm-on-vt1/+merge/342765

Unmerged revisions

6497. By Dimitri John Ledkov on 2016-10-11

Also force using tty7, by issuing chvt 7 in the start-ubiquity-dm
script. For some reason, active vt is 1 during ubiquity-dm execution.

6496. By Dimitri John Ledkov on 2016-10-11

Use older bug number

6495. By Dimitri John Ledkov on 2016-10-11

Fix typpo in the branch

6494. By Dimitri John Ledkov on 2016-10-10

Allow tty2-6 logins during maybe-ubiquity and only-ubiquity sessions,
by requiring getty.target in the ubiquity service.file. LP: #1632151

=== modified file 'debian/changelog'
--- debian/changelog	2016-10-07 00:06:21 +0000
+++ debian/changelog	2016-10-11 11:17:59 +0000
@@ -1,3 +1,12 @@
+ubiquity (16.10.14) UNRELEASED; urgency=medium
+
+  * Allow tty2-6 logins during maybe-ubiquity and only-ubiquity sessions,
+    by requiring getty.target in the ubiquity service.file. LP: #1567194.
+  * Also force using tty7, by issuing chvt 7 in the start-ubiquity-dm
+    script. For some reason, active vt is 1 during ubiquity-dm execution.
+
+ -- Dimitri John Ledkov <[e-mail]>  Tue, 11 Oct 2016 00:41:22 +0100
+
 ubiquity (16.10.13) yakkety; urgency=medium
 
   [ Blaze ]

=== modified file 'debian/ubiquity.ubiquity.service'
--- debian/ubiquity.ubiquity.service	2016-04-18 11:12:16 +0000
+++ debian/ubiquity.ubiquity.service	2016-10-11 11:17:59 +0000
@@ -1,6 +1,9 @@
 [Unit]
 Description=Ubuntu live CD installer
 Before=display-manager.service plymouth-quit.service plymouth-quit-wait.service
+After=getty.target [e-mail]
+Conflicts=[e-mail]
+Requires=getty.target
 
 [Service]
 Type=oneshot

=== modified file 'scripts/start-ubiquity-dm'
--- scripts/start-ubiquity-dm	2015-12-31 00:04:08 +0000
+++ scripts/start-ubiquity-dm	2016-10-11 11:17:59 +0000
@@ -62,6 +62,9 @@
     plymouth quit || :
     exec ubiquity noninteractive $debug
 else
+    # Plymouth on livecd appears to start on vt1, instead of vt7
+    # even with vt.handoff=7
+    chvt 7 || :
     if ! ubiquity-dm vt7 :0 ubuntu /usr/bin/ubiquity $debug $automatic $choose $ldtp --only $frontend; then
 	# has X crashed, or has ubiquity?
 	if [ "$automatic" ] && ! [ -f /var/log/installer/version ]; then