Merge lp:~xnox/ubiquity/fix-crypt-qt-page into lp:ubiquity

Proposed by Dimitri John Ledkov
Status: Merged
Merged at revision: 5909
Proposed branch: lp:~xnox/ubiquity/fix-crypt-qt-page
Merge into: lp:ubiquity
Diff against target: 66 lines (+28/-3)
3 files modified
debian/changelog (+11/-0)
ubiquity/frontend/kde_components/PartAuto.py (+13/-3)
ubiquity/frontend/kde_components/PartMan.py (+4/-0)
To merge this branch: bzr merge lp:~xnox/ubiquity/fix-crypt-qt-page
Reviewer Review Type Date Requested Status
Ubuntu Installer Team Pending
Review via email: mp+160602@code.launchpad.net
To post a comment you must log in.
lp:~xnox/ubiquity/fix-crypt-qt-page updated
5913. By Dimitri John Ledkov

[Qt Frontend] Clear use as combo box, on each iteration to avoid
duplicated entries. (LP: #1171989) Thanks merryidleness for the patch.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-04-23 12:25:58 +0000
3+++ debian/changelog 2013-04-24 13:38:26 +0000
4@@ -1,3 +1,14 @@
5+ubiquity (2.14.7) UNRELEASED; urgency=low
6+
7+ * [Qt Frontend] Do not allow to proceed from partitioning page when
8+ password is required, yet missing or does not match confirmation
9+ password. (LP: #1172059)
10+
11+ * [Qt Frontend] Clear use as combo box, on each iteration to avoid
12+ duplicated entries. (LP: #1171989) Thanks merryidleness for the patch.
13+
14+ -- Dmitrijs Ledkovs <dmitrij.ledkov@ubuntu.com> Wed, 24 Apr 2013 11:40:29 +0100
15+
16 ubiquity (2.14.6) raring; urgency=low
17
18 * Automatic update of included source packages: partman-auto 105ubuntu3
19
20=== modified file 'ubiquity/frontend/kde_components/PartAuto.py'
21--- ubiquity/frontend/kde_components/PartAuto.py 2013-02-19 11:33:07 +0000
22+++ ubiquity/frontend/kde_components/PartAuto.py 2013-04-24 13:38:26 +0000
23@@ -288,15 +288,25 @@
24 self.password.setEnabled(True)
25 self.verified_password.setEnabled(True)
26 self.badPassword.setEnabled(True)
27+ self.verify_password()
28 else:
29 self.passwordIcon.setEnabled(False)
30 self.password.setEnabled(False)
31 self.verified_password.setEnabled(False)
32 self.badPassword.setEnabled(False)
33+ self.controller.allow_go_forward(True)
34
35 #show warning if passwords do not match
36 def verify_password(self):
37- if self.password.text() != self.verified_password.text():
38+ complete = False
39+
40+ if self.password.text() == self.verified_password.text():
41+ self.badPassword.hide()
42+ complete = True
43+ else:
44 self.badPassword.show()
45- else:
46- self.badPassword.hide()
47+
48+ if not self.password.text():
49+ complete = False
50+
51+ self.controller.allow_go_forward(complete)
52
53=== modified file 'ubiquity/frontend/kde_components/PartMan.py'
54--- ubiquity/frontend/kde_components/PartMan.py 2013-02-15 16:56:45 +0000
55+++ ubiquity/frontend/kde_components/PartMan.py 2013-04-24 13:38:26 +0000
56@@ -178,6 +178,10 @@
57 dialog.partition_create_place_beginning.setChecked(True)
58
59 self.create_use_method_names = {}
60+
61+ # Remove any previous entries
62+ dialog.partition_create_use_combo.clear()
63+
64 for method, name, description in (
65 self.ctrlr.dbfilter.use_as(devpart, True)):
66 self.create_use_method_names[description] = name

Subscribers

People subscribed via source and target branches

to status/vote changes: