Merge ~xnox/ubiquity:gsd-keyboard into ubiquity:master

Proposed by Dimitri John Ledkov
Status: Merged
Merged at revision: dcd8ca25ea9ca738a194891c9121a4a8fbae571a
Proposed branch: ~xnox/ubiquity:gsd-keyboard
Merge into: ubiquity:master
Diff against target: 12 lines (+1/-0)
1 file modified
bin/ubiquity-dm (+1/-0)
Reviewer Review Type Date Requested Status
Iain Lane Approve
Review via email: mp+385742@code.launchpad.net

Commit message

ubiquity-dm: start gsd-keyboard for keyboard indicator

When installing in non-english locale, multiple keyboard layouts are
configured during the ubiquity-dm session. Users must be able to
swtich between them during installation, to e.g. type hostname in
english, and given name in native language. Without gsd-keyboard
running, keyboard indicator does not appear in the ubiquity-dm
session.

LP: #1847307

Description of the change

ubiquity-dm: start gsd-keyboard for keyboard indicator

When installing in non-english locale, multiple keyboard layouts are
configured during the ubiquity-dm session. Users must be able to
swtich between them during installation, to e.g. type hostname in
english, and given name in native language. Without gsd-keyboard
running, keyboard indicator does not appear in the ubiquity-dm
session.

LP: #1847307

To post a comment you must log in.
Revision history for this message
Iain Lane (laney) wrote :

Looks good, feel free to merge.

We should try to move to the systemd path for this really. That's what the normal desktop uses.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/bin/ubiquity-dm b/bin/ubiquity-dm
2index 4f31a31..4a7f24a 100755
3--- a/bin/ubiquity-dm
4+++ b/bin/ubiquity-dm
5@@ -533,6 +533,7 @@ EndSection
6 gsd = ['/usr/libexec/gsd-a11y-keyboard',
7 '/usr/libexec/gsd-a11y-settings',
8 '/usr/libexec/gsd-clipboard',
9+ '/usr/libexec/gsd-keyboard',
10 '/usr/libexec/gsd-media-keys',
11 '/usr/libexec/gsd-power',
12 '/usr/libexec/gsd-xsettings']

Subscribers

People subscribed via source and target branches