Merge lp:~xnox/software-properties/gnupg-fix-all-the-things into lp:software-properties
Status: | Merged | ||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Merged at revision: | 1013 | ||||||||||||||||||||||||||||
Proposed branch: | lp:~xnox/software-properties/gnupg-fix-all-the-things | ||||||||||||||||||||||||||||
Merge into: | lp:software-properties | ||||||||||||||||||||||||||||
Diff against target: |
595 lines (+181/-170) 10 files modified
add-apt-repository (+4/-4) debian/changelog (+24/-0) debian/control (+2/-2) debian/tests/add-apt-repository (+11/-7) debian/tests/control (+3/-3) debian/tests/run-tests (+0/-9) software-properties-gtk (+2/-3) software-properties-kde (+1/-5) softwareproperties/ppa.py (+71/-103) tests/test_lp.py (+63/-34) |
||||||||||||||||||||||||||||
To merge this branch: | bzr merge lp:~xnox/software-properties/gnupg-fix-all-the-things | ||||||||||||||||||||||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ubuntu Core Development Team | Pending | ||
Review via email:
|
Commit message
* ppa.py:
- rework key retrieval, instead of using hkp & gnupg/dirmngr, use https
& python's built in urllib.
- thus, add-apt-key for PPAs observes https_proxy for key retrieval
- simplify gnupg operations, depend on gpg package only, and use
import/public key operations only.
- fix unicode process output bugs, when operating in a non-UTF-8
locale, thus enabling to import keys for my ppas in C locale.
- avoid creating trustdb, or requiring any gpg-agent systemd socket to
be activated
- update tests to execute key addition fully with less things stubbed
out with mock
- stop using apt-key for installing keys
- deprecate --keyserver option, making HTTPS access to
keyserver
Description of the change
* ppa.py:
- rework key retrieval, instead of using hkp & gnupg/dirmngr, use https
& python's built in urllib.
- thus, add-apt-key for PPAs observes https_proxy for key retrieval
- simplify gnupg operations, depend on gpg package only, and use
import/public key operations only.
- fix unicode process output bugs, when operating in a non-UTF-8
locale, thus enabling to import keys for my ppas in C locale.
- avoid creating trustdb, or requiring any gpg-agent systemd socket to
be activated
- update tests to execute key addition fully with less things stubbed
out with mock
- stop using apt-key for installing keys
- deprecate --keyserver option, making HTTPS access to
keyserver
Autopkgtests pass, results e.g.:
https:/