add-apt-repository crashes on non-ascii names in PGP keys
Bug #1699086 reported by
Rob Lazzurs
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| software-properties (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
When adding the PHP 7.1 repo into Ubuntu 16.04 LTS I get the following error.
Command;
add-apt-repository ppa:ondrej/php -y
Output;
gpg: keyring `/tmp/tmprs_
gpg: keyring `/tmp/tmprs_
gpg: requesting key E5267A6C from hkp server keyserver.
gpg: /tmp/tmprs_
gpg: key E5267A6C: public key "Launchpad PPA for Ond\xc5\x99ej Sur�" imported
gpg: Total number processed: 1
gpg: imported: 1 (RSA: 1)
'ascii' codec can't decode byte 0xc5 in position 92: ordinal not in range(128)
The command exits with code 1.
Related branches
lp:~xnox/software-properties/gnupg-fix-all-the-things
- Ubuntu Core Development Team: Pending requested
-
Diff: 595 lines (+181/-170)10 files modifiedadd-apt-repository (+4/-4)
debian/changelog (+24/-0)
debian/control (+2/-2)
debian/tests/add-apt-repository (+11/-7)
debian/tests/control (+3/-3)
debian/tests/run-tests (+0/-9)
software-properties-gtk (+2/-3)
software-properties-kde (+1/-5)
softwareproperties/ppa.py (+71/-103)
tests/test_lp.py (+63/-34)
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in software-properties (Ubuntu): | |
| status: | New → Fix Released |
Revision history for this message
| Bohumir Zamecnik (bzamecnik) wrote | #2 |
Revision history for this message
| Bohumir Zamecnik (bzamecnik) wrote | #3 |
To post a comment you must log in.
This bug was fixed in the package software-properties - 0.96.24.25
---------------
software-properties (0.96.24.25) bionic; urgency=medium
* ppa.py:
- rework key retrieval, instead of using hkp & gnupg/dirmngr, use https
& python's built in urllib.
- thus, add-apt-key for PPAs observes https_proxy for key retrieval
- simplify gnupg operations, depend on gpg package only, and use
import/public key operations only.
- fix unicode process output bugs, when operating in a non-UTF-8
locale, thus enabling to import keys for my ppas in C locale.
- avoid creating trustdb, or requiring any gpg-agent systemd socket to
be activated
- update tests to execute key addition fully with less things stubbed
out with mock
- stop using apt-key for installing keys
- dirmngr is a heavy dependency and not used, and it is hard to pass
proxy information to it when invoking gpg from a non-standard homedir
- deprecate --keyserver option, making HTTPS access to
keyserver.
- LP: #1755192, LP: #1713962, LP: #1699086, LP: #1510220, LP: #1433761,
LP: #1395321, LP: #1312267
-- Dimitri John Ledkov <email address hidden> Mon, 02 Apr 2018 10:19:34 +0100