Code review comment for ~xnox/review-tools:riscv64

On Tue, Jun 23, 2020 at 4:00 PM Dimitri John Ledkov <email address hidden>
wrote:

> > LGTM. Thanks! Note, other changes are needed to make a riscv64 snap of
> the
> > review-tools, but that is a separate issue.
>
> Do review-tools in production run on the matching architecture for the
> snap under review?
> If so, this complicates bootstrap of the snaps that I did not predict.
>

They do not. Review-tools in production run on amd64 regardless of the
snaps' target architecture.

You will need an arch-specific build if you want to run review-tools to
pre-check your snaps before uploading. I believe snapcraft will try to do
this for you optionally. But AFAIK if you don't have review-tools installed
snapcraft will not barf, it'll just say you could be doing better :)

>
> At the moment, I am bootstraping by hand: snapd snapcraft core20 lxd.
> Cause all of them are snaps, and need each other to snap them. Is
> review-tools needed to be added to this mix?
>
> Or will I be allowed to upload snapd/snapcraft/core20/lxd to the store for
> the riscv64 architecture without review-tools riscv64 snap?
>
> The set of by hand bootstrapped snaps is the list required for launchpad
> to be able to build snaps and enable snap builders.
> --
>
> https://code.launchpad.net/~xnox/review-tools/+git/review-tools/+merge/386272
> Your team MyApps reviewers is requested to review the proposed merge of
> ~xnox/review-tools:riscv64 into review-tools:master.
>

--
- Daniel