Code review comment for lp:~xnox/merge-o-matic/add-proposed

 review needs-fixing

On Wed, Nov 06, 2013 at 10:35:47AM -0000, Dmitrijs Ledkovs wrote:
> # Run the merge tool
> +# Note "last one" wins
> ./produce-merges.py -X ../merge-blacklist.txt -X ../experimental.txt -X ../unstable.txt -X ../testing-proposed-updates.txt
> ./produce-merges.py -X ../merge-blacklist.txt -I ../experimental.txt -X ../unstable.txt -X ../testing-proposed-updates.txt -S experimental
> ./produce-merges.py -X ../merge-blacklist.txt -X ../experimental.txt -I ../unstable.txt -X ../testing-proposed-updates.txt -S unstable
> ./produce-merges.py -X ../merge-blacklist.txt -X ../experimental.txt -X ../unstable.txt -I ../testing-proposed-updates.txt -S testing-proposed-updates
> +./produce-merges.py -X ../merge-blacklist.txt -X ../experimental.txt -X ../unstable.txt -X ../testing-proposed-updates.txt -P
> +./produce-merges.py -X ../merge-blacklist.txt -I ../experimental.txt -X ../unstable.txt -X ../testing-proposed-updates.txt -P -S experimental
> +./produce-merges.py -X ../merge-blacklist.txt -X ../experimental.txt -I ../unstable.txt -X ../testing-proposed-updates.txt -P -S unstable
> +./produce-merges.py -X ../merge-blacklist.txt -X ../experimental.txt -X ../unstable.txt -I ../testing-proposed-updates.txt -P -S testing-proposed-updates

Can't we just do a single run (for each source suite) that looks for the
newest in trusty or trusty-proposed? I don't really like doubling the
number of runs, especially as this means we'll be doing some unnecessary
work for packages that appear merged in trusty-proposed but not yet in
trusty.

It would seem a lot more intuitive if produce-merges could infer
sensible behaviour from DISTROS["ubuntu"]["dists"] having multiple
elements.