Code review comment for ~xnox/maas-images:master

I've built the maas-images with this change in, and lots of kernel modules are added to the initramfs now on disco. Meaning that one can use encryption.

I'm not sure what you mean by running this change in the CI though. As nothing uses encryption at the moment in production.

Do you not build test maas-images yourselves using livefs builds in launchpad to test things? Do you want me to provide a new maas-images build?

Also note, that it is odd how maas-images repository is structured, since all other images we build use per-series code to build them. Ie. livecd-rootfs (for ubuntu-desktop/server/stock-cloud-images/etc), CPC code (partner cloud-images) are all maintained in per-series branches. maas-images appears to be the only one that tries to build any series images, from the same master branch.

I find it disturbing that maas-images master branch is used for e.g. building bionic images. Rather than using bionic branch.... Cause it should be normal to land changes on master, to test it out with disco. And then later choose to backport that onto bionic branch to land a change in bionic maas-images.