Merge lp:~xnox/location-service/drop-sys-events into lp:location-service/trunk

Proposed by Dimitri John Ledkov
Status: Needs review
Proposed branch: lp:~xnox/location-service/drop-sys-events
Merge into: lp:location-service/trunk
Diff against target: 19 lines (+7/-2)
1 file modified
data/ubuntu-location-service-trust-stored.conf.in (+7/-2)
To merge this branch: bzr merge lp:~xnox/location-service/drop-sys-events
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Martin Pitt Pending
Ubuntu Phablet Team Pending
Review via email: mp+246050@code.launchpad.net

Commit message

Migrate from :sys:started events to dbus owner signals.

Description of the change

Migrate from :sys:started events to dbus owner signals.

To post a comment you must log in.
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

When system upstart goes away, :sys:started/stopped/starting/stopping events will go away.

One option is to introduce a user session event bridge which will relay similar events from systemd. I have a working prototype for that, however incomplete information is exposed by systemd at the moment.

Another option is to key onto approximately equivalent events which are already available.

This is a master bug to track all users and port them.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Unmerged revisions

156. By Dimitri John Ledkov

Migrate from :sys:started events to dbus owner signals.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'data/ubuntu-location-service-trust-stored.conf.in'
--- data/ubuntu-location-service-trust-stored.conf.in 2014-09-19 14:36:51 +0000
+++ data/ubuntu-location-service-trust-stored.conf.in 2015-01-11 00:44:23 +0000
@@ -3,9 +3,14 @@
3# try to start this on session startup or once ubuntu-location-service finished3# try to start this on session startup or once ubuntu-location-service finished
4# starting; if dbus is available and location-service isn't or vice-versa,4# starting; if dbus is available and location-service isn't or vice-versa,
5# startup will fail but the next event firing will trigger another start5# startup will fail but the next event firing will trigger another start
6#
7# Start on session dbus is spawned on ubuntu-touch session or
8# com.ubuntu.location.Service bus name appears on system dbus
9# Stop on desktop end or com.ubuntu.location.Service bus name disappearing on system dbus
6start on (started dbus and xsession SESSION=ubuntu-touch) or \10start on (started dbus and xsession SESSION=ubuntu-touch) or \
7 :sys:started JOB=ubuntu-location-service11 dbus SIGNAL='NameOwnerChanged' BUS='system' INTERFACE='org.freedesktop.DBus' OBJPATH='/org/freedesktop/DBus' SENDER='org.freedesktop.DBus' ARG0='com.ubuntu.location.Service' ARG1='' ARG2='*'
8stop on desktop-end or :sys:stopping JOB=ubuntu-location-service12stop on desktop-end or \
13 dbus SIGNAL='NameOwnerChanged' BUS='system' INTERFACE='org.freedesktop.DBus' OBJPATH='/org/freedesktop/DBus' SENDER='org.freedesktop.DBus' ARG0='com.ubuntu.location.Service' ARG1='*' ARG2=''
914
10respawn15respawn
1116

Subscribers

People subscribed via source and target branches