Code review comment for lp:~xnox/livecd-rootfs/force-resolved-stub-resolver

Revision history for this message
Steve Langasek (vorlon) wrote :

Most of the resolv.conf handling in livecd-rootfs doesn't require any knowledge of the policy of where /etc/resolv.conf should point. We should not change this. The target of /etc/resolv.conf should be set up by the systemd maintainer scripts, and livecd-rootfs should only need to manage the target on a temporary basis so that there's working dns resolution within the chroot as part of the build.

So most of these references should not be changed. And live-build/ubuntu-server/hooks/99-fix-resolvconf.chroot probably needs to be dropped completely - it should be superfluous under both resolvconf and systemd.

review: Needs Fixing

« Back to merge proposal