Merge lp:~xnox/indicator-network/lp1648360 into lp:indicator-network

Proposed by Dimitri John Ledkov
Status: Merged
Approved by: Pete Woods
Approved revision: 649
Merged at revision: 660
Proposed branch: lp:~xnox/indicator-network/lp1648360
Merge into: lp:indicator-network
Diff against target: 95 lines (+1/-60)
5 files modified
data/CMakeLists.txt (+0/-42)
data/indicator-network.desktop.in (+0/-8)
data/indicator-network.upstart.desktop.in (+0/-8)
debian/indicator-network.install (+0/-2)
debian/indicator-network.maintscript (+1/-0)
To merge this branch: bzr merge lp:~xnox/indicator-network/lp1648360
Reviewer Review Type Date Requested Status
dobey (community) Approve
Review via email: mp+312847@code.launchpad.net

Commit message

Remove xdg autolaunch desktop files

Description of the change

Remove xdg autolaunch desktop files because they are redundant in zesty and up, and do not work correctly in the zesty systemd unity7 session.

All systems have systemd user sessions now, and if one wants this indicator in particular session they should be a .wants symlink shipped.

To post a comment you must log in.
Revision history for this message
dobey (dobey) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'data/CMakeLists.txt'
--- data/CMakeLists.txt 2016-07-19 10:15:52 +0000
+++ data/CMakeLists.txt 2016-12-08 16:52:48 +0000
@@ -100,45 +100,3 @@
100###########################100###########################
101101
102add_schema ("com.canonical.indicator.network.gschema.xml")102add_schema ("com.canonical.indicator.network.gschema.xml")
103
104###########################
105# XDG Autostart File
106###########################
107
108# where to install
109set (XDG_AUTOSTART_DIR "/etc/xdg/autostart")
110message (STATUS "${XDG_AUTOSTART_DIR} is the DBus Service File install dir")
111
112set (XDG_AUTOSTART_NAME "${CMAKE_PROJECT_NAME}.desktop")
113set (XDG_AUTOSTART_FILE "${CMAKE_CURRENT_BINARY_DIR}/${XDG_AUTOSTART_NAME}")
114set (XDG_AUTOSTART_FILE_IN "${CMAKE_CURRENT_SOURCE_DIR}/${XDG_AUTOSTART_NAME}.in")
115
116# build it
117set (pkglibexecdir "${CMAKE_INSTALL_FULL_PKGLIBEXECDIR}")
118configure_file ("${XDG_AUTOSTART_FILE_IN}" "${XDG_AUTOSTART_FILE}")
119
120# install it
121install (FILES "${XDG_AUTOSTART_FILE}"
122 DESTINATION "${XDG_AUTOSTART_DIR}")
123
124###########################
125# Upstart XDG Autostart Override
126###########################
127
128# where to install
129set (UPSTART_XDG_AUTOSTART_DIR "${CMAKE_INSTALL_FULL_DATAROOTDIR}/upstart/xdg/autostart")
130message (STATUS "${UPSTART_XDG_AUTOSTART_DIR} is the Upstart XDG autostart override dir")
131
132set (UPSTART_XDG_AUTOSTART_NAME "${CMAKE_PROJECT_NAME}.upstart.desktop")
133set (UPSTART_XDG_AUTOSTART_FILE "${CMAKE_CURRENT_BINARY_DIR}/${UPSTART_XDG_AUTOSTART_NAME}")
134set (UPSTART_XDG_AUTOSTART_FILE_IN "${CMAKE_CURRENT_SOURCE_DIR}/${UPSTART_XDG_AUTOSTART_NAME}.in")
135
136# build it
137set (pkglibexecdir "${CMAKE_INSTALL_FULL_PKGLIBEXECDIR}")
138configure_file ("${UPSTART_XDG_AUTOSTART_FILE_IN}" "${UPSTART_XDG_AUTOSTART_FILE}")
139
140# install it
141install (FILES "${UPSTART_XDG_AUTOSTART_FILE}"
142 DESTINATION "${UPSTART_XDG_AUTOSTART_DIR}"
143 RENAME "${XDG_AUTOSTART_NAME}")
144
145103
=== removed file 'data/indicator-network.desktop.in'
--- data/indicator-network.desktop.in 2014-02-26 16:37:56 +0000
+++ data/indicator-network.desktop.in 1970-01-01 00:00:00 +0000
@@ -1,8 +0,0 @@
1[Desktop Entry]
2Type=Application
3Name=Indicator Network
4Exec=@NETWORK_SERVICE@
5StartupNotify=false
6Terminal=false
7OnlyShowIn=Unity;GNOME;
8AutostartCondition=GNOME3 unless-session gnome
90
=== removed file 'data/indicator-network.upstart.desktop.in'
--- data/indicator-network.upstart.desktop.in 2014-04-09 20:49:14 +0000
+++ data/indicator-network.upstart.desktop.in 1970-01-01 00:00:00 +0000
@@ -1,8 +0,0 @@
1[Desktop Entry]
2Type=Application
3Name=Indicator Network
4Exec=@NETWORK_SERVICE@
5StartupNotify=false
6Terminal=false
7Hidden=true
8OnlyShowIn=Unity;
90
=== modified file 'debian/indicator-network.install'
--- debian/indicator-network.install 2016-07-19 10:15:52 +0000
+++ debian/indicator-network.install 2016-12-08 16:52:48 +0000
@@ -1,9 +1,7 @@
1usr/share/upstart/xdg/autostart/indicator-network.desktop
2usr/share/upstart/sessions/*1usr/share/upstart/sessions/*
3usr/share/upstart/systemd-session2usr/share/upstart/systemd-session
4usr/share/glib-2.0/schemas/com.canonical.indicator.network.gschema.xml3usr/share/glib-2.0/schemas/com.canonical.indicator.network.gschema.xml
5usr/share/unity/indicators/com.canonical.indicator.network4usr/share/unity/indicators/com.canonical.indicator.network
6usr/lib/*/indicator-network/*5usr/lib/*/indicator-network/*
7usr/lib/systemd6usr/lib/systemd
8etc/xdg/autostart/indicator-network.desktop
9usr/share/locale7usr/share/locale
108
=== added file 'debian/indicator-network.maintscript'
--- debian/indicator-network.maintscript 1970-01-01 00:00:00 +0000
+++ debian/indicator-network.maintscript 2016-12-08 16:52:48 +0000
@@ -0,0 +1,1 @@
1rm_conffile etc/xdg/autostart/indicator-network.desktop

Subscribers

People subscribed via source and target branches