Merge lp:~xnox/gnome-menus/ubuntu-py3 into lp:~ubuntu-desktop/gnome-menus/ubuntu

Proposed by Dimitri John Ledkov
Status: Merged
Merged at revision: 130
Proposed branch: lp:~xnox/gnome-menus/ubuntu-py3
Merge into: lp:~ubuntu-desktop/gnome-menus/ubuntu
Diff against target: 152 lines (+29/-22)
6 files modified
debian/changelog (+6/-0)
debian/control (+4/-5)
debian/control.in (+3/-3)
debian/gnome-menus-blacklist (+14/-13)
debian/menus.blacklist (+1/-0)
debian/rules (+1/-1)
To merge this branch: bzr merge lp:~xnox/gnome-menus/ubuntu-py3
Reviewer Review Type Date Requested Status
Iain Lane Pending
Barry Warsaw Pending
Robert Ancell Pending
Ubuntu Desktop Pending
Review via email: mp+136303@code.launchpad.net

Description of the change

We don't actually use gnome-menus-blacklist directly, but I ported it to python3 anyway to drop the python2 dependency from this seeded package.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2012-11-14 21:41:04 +0000
+++ debian/changelog 2012-11-27 00:47:36 +0000
@@ -1,3 +1,9 @@
1gnome-menus (3.6.1-0ubuntu2) UNRELEASED; urgency=low
2
3 * Port gnome-menus-blacklist to python3.
4
5 -- Dmitrijs Ledkovs <dmitrij.ledkov@ubuntu.com> Tue, 20 Nov 2012 01:27:03 +0000
6
1gnome-menus (3.6.1-0ubuntu1) raring; urgency=low7gnome-menus (3.6.1-0ubuntu1) raring; urgency=low
28
3 * New upstream release9 * New upstream release
410
=== modified file 'debian/control'
--- debian/control 2012-05-21 17:15:55 +0000
+++ debian/control 2012-11-27 00:47:36 +0000
@@ -2,23 +2,22 @@
2# 2#
3# Modifications should be made to debian/control.in instead.3# Modifications should be made to debian/control.in instead.
4# This file is regenerated automatically in the clean target.4# This file is regenerated automatically in the clean target.
5
6Source: gnome-menus5Source: gnome-menus
7Section: gnome6Section: gnome
8Priority: optional7Priority: optional
9Maintainer: Ubuntu Desktop Team <ubuntu-desktop@lists.ubuntu.com>8Maintainer: Ubuntu Desktop Team <ubuntu-desktop@lists.ubuntu.com>
10XSBC-Original-Maintainer: Debian GNOME Maintainers <pkg-gnome-maintainers@lists.alioth.debian.org>9XSBC-Original-Maintainer: Debian GNOME Maintainers <pkg-gnome-maintainers@lists.alioth.debian.org>
11Uploaders: Debian GNOME Maintainers <pkg-gnome-maintainers@lists.alioth.debian.org>, Michael Biebl <biebl@debian.org>, Sjoerd Simons <sjoerd@debian.org>10Uploaders: Debian GNOME Maintainers <pkg-gnome-maintainers@lists.alioth.debian.org>
12Build-Depends: debhelper (>= 8.1.0~),11Build-Depends: debhelper (>= 8.1.0~),
13 cdbs (>= 0.4.73),12 cdbs (>= 0.4.73),
14 libglib2.0-dev (>= 2.30.0),13 libglib2.0-dev (>= 2.30.0),
15 gnome-pkg-tools,14 gnome-pkg-tools,
16 python (>= 2.6.6-3~),15 python3 (>= 3.1),
17 intltool (>= 0.40.0),16 intltool (>= 0.40.0),
18 libgirepository1.0-dev (>= 0.10.7-1~),17 libgirepository1.0-dev (>= 0.10.7-1~),
19 gobject-introspection (>= 0.9.12-4~)18 gobject-introspection (>= 0.9.12-4~)
20Standards-Version: 3.9.319Standards-Version: 3.9.3
21X-Python-Version: >= 2.320X-Python3-Version: >= 3.1
22Vcs-Bzr: https://code.launchpad.net/~ubuntu-desktop/gnome-menus/ubuntu21Vcs-Bzr: https://code.launchpad.net/~ubuntu-desktop/gnome-menus/ubuntu
2322
24Package: gnome-menus23Package: gnome-menus
@@ -26,7 +25,7 @@
26Pre-Depends: ${misc:Pre-Depends}25Pre-Depends: ${misc:Pre-Depends}
27Depends: ${shlibs:Depends},26Depends: ${shlibs:Depends},
28 ${misc:Depends},27 ${misc:Depends},
29 ${python:Depends}28 ${python3:Depends}
30Breaks: gnome-panel (<< 2.91),29Breaks: gnome-panel (<< 2.91),
31 gnome-control-center (<< 2.91),30 gnome-control-center (<< 2.91),
32 alacarte (<< 0.13.2-2)31 alacarte (<< 0.13.2-2)
3332
=== modified file 'debian/control.in'
--- debian/control.in 2012-05-21 17:15:55 +0000
+++ debian/control.in 2012-11-27 00:47:36 +0000
@@ -8,12 +8,12 @@
8 cdbs (>= 0.4.73),8 cdbs (>= 0.4.73),
9 libglib2.0-dev (>= 2.30.0),9 libglib2.0-dev (>= 2.30.0),
10 gnome-pkg-tools,10 gnome-pkg-tools,
11 python (>= 2.6.6-3~),11 python3 (>= 3.1),
12 intltool (>= 0.40.0),12 intltool (>= 0.40.0),
13 libgirepository1.0-dev (>= 0.10.7-1~),13 libgirepository1.0-dev (>= 0.10.7-1~),
14 gobject-introspection (>= 0.9.12-4~)14 gobject-introspection (>= 0.9.12-4~)
15Standards-Version: 3.9.315Standards-Version: 3.9.3
16X-Python-Version: >= 2.316X-Python3-Version: >= 3.1
17Vcs-Bzr: https://code.launchpad.net/~ubuntu-desktop/gnome-menus/ubuntu17Vcs-Bzr: https://code.launchpad.net/~ubuntu-desktop/gnome-menus/ubuntu
1818
19Package: gnome-menus19Package: gnome-menus
@@ -21,7 +21,7 @@
21Pre-Depends: ${misc:Pre-Depends}21Pre-Depends: ${misc:Pre-Depends}
22Depends: ${shlibs:Depends},22Depends: ${shlibs:Depends},
23 ${misc:Depends},23 ${misc:Depends},
24 ${python:Depends}24 ${python3:Depends}
25Breaks: gnome-panel (<< 2.91),25Breaks: gnome-panel (<< 2.91),
26 gnome-control-center (<< 2.91),26 gnome-control-center (<< 2.91),
27 alacarte (<< 0.13.2-2)27 alacarte (<< 0.13.2-2)
2828
=== modified file 'debian/gnome-menus-blacklist'
--- debian/gnome-menus-blacklist 2011-05-16 11:00:23 +0000
+++ debian/gnome-menus-blacklist 2012-11-27 00:47:36 +0000
@@ -1,4 +1,4 @@
1#! /usr/bin/python1#! /usr/bin/python3
22
3sourcedir = "/usr/share/applications"3sourcedir = "/usr/share/applications"
4destdir = "/usr/share/gnome/applications"4destdir = "/usr/share/gnome/applications"
@@ -9,11 +9,12 @@
9# Parse blacklist file9# Parse blacklist file
10blacklist = []10blacklist = []
11try:11try:
12 for l in file (blacklist_file):12 with open(blacklist_file, 'r', encoding='utf_8') as fp:
13 l = l.strip()13 for l in fp.readlines():
14 if l.startswith("#"):14 l = l.strip()
15 continue15 if l.startswith("#"):
16 blacklist.append(l)16 continue
17 blacklist.append(l)
17except IOError:18except IOError:
18 sys.stderr.write("Warning: %s cannot be opened\n"%blacklist_file)19 sys.stderr.write("Warning: %s cannot be opened\n"%blacklist_file)
1920
@@ -57,13 +58,13 @@
57 # Copy file, adding a NoDisplay flag58 # Copy file, adding a NoDisplay flag
58 if not os.path.isdir (absdir):59 if not os.path.isdir (absdir):
59 os.makedirs (absdir)60 os.makedirs (absdir)
60 out = file (destfile, "w")61 with open(destfile, 'wt', encoding='utf_8') as fp_out:
61 for l in file (sourcefile):62 with open(sourcefile, 'rt', encoding='utf_8') as fp_in:
62 if l.startswith ("NoDisplay="):63 for l in fp_in.readlines():
63 continue64 if l.startswith ("NoDisplay="):
64 out.write(l)65 continue
65 out.write ("NoDisplay=true\n")66 fp_out.write(l)
66 out.close()67 fp_out.write("NoDisplay=true\n")
6768
68 # Set mtime so that the file is not touched unless it has changed69 # Set mtime so that the file is not touched unless it has changed
69 os.utime (destfile, (source_time, source_time))70 os.utime (destfile, (source_time, source_time))
7071
=== modified file 'debian/menus.blacklist'
--- debian/menus.blacklist 2012-05-21 17:15:55 +0000
+++ debian/menus.blacklist 2012-11-27 00:47:36 +0000
@@ -1,3 +1,4 @@
1# -*- coding: utf-8 -*-
1# openjdk-62# openjdk-6
2openjdk-6-policytool.desktop3openjdk-6-policytool.desktop
34
45
=== modified file 'debian/rules'
--- debian/rules 2012-02-08 10:35:07 +0000
+++ debian/rules 2012-11-27 00:47:36 +0000
@@ -17,7 +17,7 @@
17build/gnome-menus:: $(OUTFILES)17build/gnome-menus:: $(OUTFILES)
1818
19binary-install/gnome-menus::19binary-install/gnome-menus::
20 dh_python2 -pgnome-menus20 dh_python3 -pgnome-menus
2121
22clean::22clean::
23 -rm -f $(OUTFILES)23 -rm -f $(OUTFILES)

Subscribers

People subscribed via source and target branches