Code review comment for lp:~xnox/bzr-keywords/more-keywords

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 3/2/2011 1:36 PM, Jelmer Vernooij wrote:
> You have been requested to review the proposed merge of lp:~dmitrij.ledkov/bzr-keywords/more-keywords into lp:bzr-keywords.
>
> For more details, see:
> https://code.launchpad.net/~dmitrij.ledkov/bzr-keywords/more-keywords/+merge/23626
>
> This branch adds support for
> Revno - RevNo of the Revision-Id
> CurRevno - Current Revno of the tree (eg. bzr cat $file --keywords=cooked --revision=$i will print $i and it doesn't matter when that file was actually last modified)
> CurRevid - Same as above but id
>
> I've tried hard to get testsuite coverage for this. But with current setup revno's are not generated / committed && I've tried writing one blackbox style, but then keywords plugin wasn't getting imported at all such that self.run_bzr("cat $file --keywords=coocked") would complain that keywords is not a valid argument =(
>
> One more cool thing. I've added a hook such that on branch_tip_change files which are marked to be filtered get refreshed =) so you no longer need to remove-tree && co . to get new values like for example CurRev* and similar stuff.
>
> Hope we can work on fixing test-suite.
>

Is this still a serious proposal? If you're still looking for feedback,
I'll be happy to actually review it and comment. But I'm going to skip
it for now, assuming that it is just dormant.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk101P4ACgkQJdeBCYSNAAOe6ACfTuhPSj+7GRyKZm2AcYX8IZwe
6QIAoJGQ72rzrKlzqGY15JXHam2O/Olr
=YNDd
-----END PGP SIGNATURE-----