Code review comment for lp:~xnox/bzr-dbus/pygi

Revision history for this message
Martin Pitt (pitti) wrote :

This looks good to me, thanks! Don't worry about the IOChannel warning; I think deprecating this one was a bit overzealous, supporting this mode is not all that expensive (unlike calling it with wrong arguments). I dropped the warning in

http://git.gnome.org/browse/pygobject/commit/?id=945263a8

review: Approve

« Back to merge proposal