Merge ~xnox/autopkgtest-cloud:https-everything into autopkgtest-cloud:master

[Dimitri John Ledkov]

Use https url for github status

Rewrite incoming request, as if it came over https, such that url generated in the login/submit form is also https, thus preventing browser errors which claim that http->https redirect is insecure.

[Iain Lane (laney)]

We'll go with https://code.launchpad.net/~ubuntu-release/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/407450

thanks!

review: Disapprove

Unmerged commits

dcd50f6... by Dimitri John Ledkov on 2021-08-20

request: enforce https in the webform callbacks

Signed-off-by: Dimitri John Ledkov <email address hidden>

9d3a192... by Dimitri John Ledkov on 2021-08-20

request: use https for github test pending page

Signed-off-by: Dimitri John Ledkov <email address hidden>

diff --git a/charms/focal/autopkgtest-web/webcontrol/request/app.py b/charms/focal/autopkgtest-web/webcontrol/request/app.py
index 66e3539..78a9770 100644
--- a/charms/focal/autopkgtest-web/webcontrol/request/app.py
+++ b/charms/focal/autopkgtest-web/webcontrol/request/app.py
@@ -116,6 +116,9 @@ oid = OpenID(app, os.path.join(PATH, 'openid'), safe_roots=[])
 def index_root():
     """Handle all GET requests."""
     session.permanent = True
+    # even if request came internally over http from haproxy
+    # change scheme to https, such that browser redirects work
+    request.scheme = 'https'
     session['next'] = maybe_escape(request.url)
     nick = maybe_escape(session.get('nickname'))
 
@@ -183,7 +186,7 @@ def index_root():
                   'context': '%s-%s' % (params['release'], params['arch']),
                   'description': 'autopkgtest running',
                   'target_url':
-                  'http://autopkgtest.ubuntu.com/running#pkg-' + params['package']}
+                  'https://autopkgtest.ubuntu.com/running#pkg-' + params['package']}
         s.post_json(statuses_url, status,
                     os.path.expanduser('~/github-status-credentials.txt'),
                     params['package'])