Code review comment for lp:~xnox/apt-btrfs-snapshot/py3

Revision history for this message
Michael Vogt (mvo) wrote :

Thanks for your work on this branch!

it looks good. One comment below:

On Mon, Jun 11, 2012 at 01:20:25PM -0000, Dmitrijs Ledkovs wrote:
> - def test_fstab_detect_snapshot(self):
> + @mock.patch('os.path.exists', side_effect=lambda f: f in ('/sbin/btrfs'))

This seems this requires python-mock 0.8, it would be nice if that
would still work on 12.04 for now if its not too much hassle to make
it easy for contributors to hack on it without the need to upgrade to
quantal just yet.

We should probably add a generic pyflakes and pep8 test to the tests
dir, I will do that in a bit.

Thanks,
 Michael

« Back to merge proposal