Code review comment for lp:~xintx-ua/command-not-found/add-install-support

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

21 + locale.setlocale(locale.LC_ALL, '')

Why are you setting this?

+ if return_code not in (0,256): #256 = user rejected installation
29 + print >> sys.stderr, _("A problem occured during installation. apt-get returned %d") % return_code

I would just do if return_code != 0, I don't know if there is any value as the failing installation probably leaves enough information to the user anyway.

« Back to merge proposal