Merge lp:~xfactor973/charm-helpers/ceph-to-rados-fix into lp:charm-helpers

Proposed by Chris Holcombe
Status: Merged
Merged at revision: 547
Proposed branch: lp:~xfactor973/charm-helpers/ceph-to-rados-fix
Merge into: lp:charm-helpers
Diff against target: 25 lines (+2/-2)
2 files modified
charmhelpers/contrib/storage/linux/ceph.py (+1/-1)
tests/contrib/storage/test_linux_ceph.py (+1/-1)
To merge this branch: bzr merge lp:~xfactor973/charm-helpers/ceph-to-rados-fix
Reviewer Review Type Date Requested Status
Charles Butler (community) Approve
Review via email: mp+288559@code.launchpad.net

Description of the change

I copy pasted a command from ceph's wiki incorrectly. The ceph command is really a rados command.

To post a comment you must log in.
Revision history for this message
Charles Butler (lazypower) wrote :

+1 LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'charmhelpers/contrib/storage/linux/ceph.py'
--- charmhelpers/contrib/storage/linux/ceph.py 2016-03-04 18:14:29 +0000
+++ charmhelpers/contrib/storage/linux/ceph.py 2016-03-09 18:28:53 +0000
@@ -173,7 +173,7 @@
173 elif mode == 'writeback':173 elif mode == 'writeback':
174 check_call(['ceph', '--id', self.service, 'osd', 'tier', 'cache-mode', cache_pool, 'forward'])174 check_call(['ceph', '--id', self.service, 'osd', 'tier', 'cache-mode', cache_pool, 'forward'])
175 # Flush the cache and wait for it to return175 # Flush the cache and wait for it to return
176 check_call(['ceph', '--id', self.service, '-p', cache_pool, 'cache-flush-evict-all'])176 check_call(['rados', '--id', self.service, '-p', cache_pool, 'cache-flush-evict-all'])
177 check_call(['ceph', '--id', self.service, 'osd', 'tier', 'remove-overlay', self.name])177 check_call(['ceph', '--id', self.service, 'osd', 'tier', 'remove-overlay', self.name])
178 check_call(['ceph', '--id', self.service, 'osd', 'tier', 'remove', self.name, cache_pool])178 check_call(['ceph', '--id', self.service, 'osd', 'tier', 'remove', self.name, cache_pool])
179179
180180
=== modified file 'tests/contrib/storage/test_linux_ceph.py'
--- tests/contrib/storage/test_linux_ceph.py 2016-03-04 18:14:29 +0000
+++ tests/contrib/storage/test_linux_ceph.py 2016-03-09 18:28:53 +0000
@@ -221,7 +221,7 @@
221 p.remove_cache_tier(cache_pool='cacher')221 p.remove_cache_tier(cache_pool='cacher')
222 self.check_call.assert_has_calls([222 self.check_call.assert_has_calls([
223 call(['ceph', '--id', 'admin', 'osd', 'tier', 'cache-mode', 'cacher', 'forward']),223 call(['ceph', '--id', 'admin', 'osd', 'tier', 'cache-mode', 'cacher', 'forward']),
224 call(['ceph', '--id', 'admin', '-p', 'cacher', 'cache-flush-evict-all']),224 call(['rados', '--id', 'admin', '-p', 'cacher', 'cache-flush-evict-all']),
225 call(['ceph', '--id', 'admin', 'osd', 'tier', 'remove-overlay', 'test']),225 call(['ceph', '--id', 'admin', 'osd', 'tier', 'remove-overlay', 'test']),
226 call(['ceph', '--id', 'admin', 'osd', 'tier', 'remove', 'test', 'cacher']),226 call(['ceph', '--id', 'admin', 'osd', 'tier', 'remove', 'test', 'cacher']),
227 ])227 ])

Subscribers

People subscribed via source and target branches