Code review comment for lp:~xfactor973/charm-helpers/ceph-functions

Hi Chris

I've tried every which way to get the unit tests to pass under python3, but even in a clean trusty container, I see the same failures.

unittest.expectedFailure is to catchall for your intent and was masking a number of mock setup failures under python2, which got raised as errors under python3.

I've reworked to use assertRaises and fixed another misc issue:

  https://code.launchpad.net/~james-page/charm-helpers/assertRaises/+merge/279990

With this branch merged, all tests pass.