Code review comment for lp:~xfactor973/charm-helpers/ceph-functions

Hi Chris

I'm still seeing test failures under python3:

======================================================================
ERROR: tests.contrib.storage.test_linux_ceph.CephUtilsTests.test_erasure_pool_create_failed
----------------------------------------------------------------------
testtools.testresult.real._StringException: Traceback (most recent call last):
  File "/home/jamespage/src/charm-helpers/charm-helpers/tests/contrib/storage/test_linux_ceph.py", line 270, in test_erasure_pool_create_failed
    p.create()
  File "/home/jamespage/src/charm-helpers/charm-helpers/charmhelpers/contrib/storage/linux/ceph.py", line 228, in create
    erasure_profile = get_erasure_profile(service=self.service, name=self.erasure_code_profile)
  File "/home/jamespage/src/charm-helpers/charm-helpers/charmhelpers/contrib/storage/linux/ceph.py", line 265, in get_erasure_profile
    return json.loads(out)
  File "/usr/lib/python3.4/json/__init__.py", line 312, in loads
    s.__class__.__name__))
TypeError: the JSON object must be str, not 'MagicMock'

======================================================================
ERROR: tests.contrib.storage.test_linux_ceph.CephUtilsTests.test_get_cache_mode
----------------------------------------------------------------------
testtools.testresult.real._StringException: Traceback (most recent call last):
  File "/home/jamespage/src/charm-helpers/charm-helpers/tests/contrib/storage/test_linux_ceph.py", line 389, in test_get_cache_mode
    cache_mode = ceph_utils.get_cache_mode(service='admin', pool_name='rbd')
  File "/home/jamespage/src/charm-helpers/charm-helpers/charmhelpers/contrib/storage/linux/ceph.py", line 434, in get_cache_mode
    osd_json = json.loads(out)
  File "/usr/lib/python3.4/json/__init__.py", line 312, in loads
    s.__class__.__name__))
TypeError: the JSON object must be str, not 'bytes'

======================================================================
ERROR: tests.contrib.storage.test_linux_ceph.CephUtilsTests.test_pool_set_fails
----------------------------------------------------------------------
testtools.testresult.real._StringException: Traceback (most recent call last):
  File "/home/jamespage/src/charm-helpers/charm-helpers/tests/contrib/storage/test_linux_ceph.py", line 304, in test_pool_set_fails
    ceph_utils.pool_set(service='admin', pool_name='data', key='test', value=2)
  File "/home/jamespage/src/charm-helpers/charm-helpers/charmhelpers/contrib/storage/linux/ceph.py", line 281, in pool_set
    check_call(cmd)
  File "/home/jamespage/src/charm-helpers/charm-helpers/.venv3/lib/python3.4/site-packages/mock.py", line 955, in __call__
    return _mock_self._mock_call(*args, **kwargs)
  File "/home/jamespage/src/charm-helpers/charm-helpers/.venv3/lib/python3.4/site-packages/mock.py", line 1010, in _mock_call
    raise effect
TypeError: __init__() missing 2 required positional arguments: 'returncode' and 'cmd'

======================================================================
ERROR: tests.contrib.storage.test_linux_ceph.CephUtilsTests.test_replicated_pool_create_failed
----------------------------------------------------------------------
testtools.testresult.real._StringException: Traceback (most recent call last):
  File "/home/jamespage/src/charm-helpers/charm-helpers/tests/contrib/storage/test_linux_ceph.py", line 258, in test_replicated_pool_create_failed
    p.create()
  File "/home/jamespage/src/charm-helpers/charm-helpers/charmhelpers/contrib/storage/linux/ceph.py", line 214, in create
    check_call(cmd)
  File "/home/jamespage/src/charm-helpers/charm-helpers/.venv3/lib/python3.4/site-packages/mock.py", line 955, in __call__
    return _mock_self._mock_call(*args, **kwargs)
  File "/home/jamespage/src/charm-helpers/charm-helpers/.venv3/lib/python3.4/site-packages/mock.py", line 1010, in _mock_call
    raise effect
TypeError: __init__() missing 2 required positional arguments: 'returncode' and 'cmd'

======================================================================
ERROR: tests.contrib.storage.test_linux_ceph.CephUtilsTests.test_snapshot_pool_fails
----------------------------------------------------------------------
testtools.testresult.real._StringException: Traceback (most recent call last):
  File "/home/jamespage/src/charm-helpers/charm-helpers/tests/contrib/storage/test_linux_ceph.py", line 316, in test_snapshot_pool_fails
    ceph_utils.snapshot_pool(service='admin', pool_name='data', snapshot_name='test-snap-1')
  File "/home/jamespage/src/charm-helpers/charm-helpers/charmhelpers/contrib/storage/linux/ceph.py", line 296, in snapshot_pool
    check_call(cmd)
  File "/home/jamespage/src/charm-helpers/charm-helpers/.venv3/lib/python3.4/site-packages/mock.py", line 955, in __call__
    return _mock_self._mock_call(*args, **kwargs)
  File "/home/jamespage/src/charm-helpers/charm-helpers/.venv3/lib/python3.4/site-packages/mock.py", line 1010, in _mock_call
    raise effect
TypeError: __init__() missing 2 required positional arguments: 'returncode' and 'cmd'

======================================================================
ERROR: tests.contrib.storage.test_linux_ceph.CephUtilsTests.test_validator_invalid_range
----------------------------------------------------------------------
testtools.testresult.real._StringException: Traceback (most recent call last):
  File "/home/jamespage/src/charm-helpers/charm-helpers/tests/contrib/storage/test_linux_ceph.py", line 161, in test_validator_invalid_range
    valid_range=[0])
  File "/home/jamespage/src/charm-helpers/charm-helpers/charmhelpers/contrib/storage/linux/ceph.py", line 110, in validator
    "List must be [min,max]".format(valid_range, value))
ValueError: Invalid valid_range list of [0] for 1. List must be [min,max]

======================================================================
FAIL: tests.contrib.storage.test_linux_ceph.CephUtilsTests.test_validator_invalid_string_list
----------------------------------------------------------------------
testtools.testresult.real._StringException: Traceback (most recent call last):
  File "/home/jamespage/src/charm-helpers/charm-helpers/tests/contrib/storage/test_linux_ceph.py", line 168, in test_validator_invalid_string_list
    valid_range=["valid", "list", "of", "strings"])
  File "/home/jamespage/src/charm-helpers/charm-helpers/charmhelpers/contrib/storage/linux/ceph.py", line 104, in validator
    "{} is not in the list {}".format(value, valid_range)
AssertionError: foo is not in the list ['valid', 'list', 'of', 'strings']