Merge ~xavpaice/charm-nagios:lp1827159 into ~nagios-charmers/charm-nagios:master

Proposed by Xav Paice
Status: Merged
Approved by: Xav Paice
Approved revision: 71f8aba2a2a5a4e9fbab1ce1e7ae79948b76e3a7
Merged at revision: 6f5e177f0f718478cbaaab85ab3c32f4ee55bf16
Proposed branch: ~xavpaice/charm-nagios:lp1827159
Merge into: ~nagios-charmers/charm-nagios:master
Diff against target: 27 lines (+9/-1)
1 file modified
hooks/templates/localhost_nagios2.cfg.tmpl (+9/-1)
Reviewer Review Type Date Requested Status
James Hebden (community) Approve
Review via email: mp+366741@code.launchpad.net

This proposal supersedes a proposal from 2019-05-01.

Commit message

Add custom disk monitor for nagios host

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote : Posted in a previous version of this proposal

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
James Hebden (ec0) wrote : Posted in a previous version of this proposal

Just one comment on the name of the service, but other than that, the technical aspects of the change make sense and LGTM.

review: Needs Fixing
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
James Hebden (ec0) wrote :

LGTM

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 6f5e177f0f718478cbaaab85ab3c32f4ee55bf16

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/hooks/templates/localhost_nagios2.cfg.tmpl b/hooks/templates/localhost_nagios2.cfg.tmpl
index 3cd69e1..18920ed 100644
--- a/hooks/templates/localhost_nagios2.cfg.tmpl
+++ b/hooks/templates/localhost_nagios2.cfg.tmpl
@@ -20,6 +20,14 @@ define host{
20 icon_image base/ubuntu.png20 icon_image base/ubuntu.png
21 }21 }
2222
23
24
25# 'check_all_disks_no_squashfs' command definition
26define command{
27 command_name check_all_disks_no_squashfs
28 command_line /usr/lib/nagios/plugins/check_disk -w '$ARG1$' -c '$ARG2$' -e -X squashfs
29 }
30
23# Define a service to check the disk space of the root partition31# Define a service to check the disk space of the root partition
24# on the local machine. Warning if < 20% free, critical if32# on the local machine. Warning if < 20% free, critical if
25# < 10% free space on partition.33# < 10% free space on partition.
@@ -31,7 +39,7 @@ define service{
31{%- if is_container %}39{%- if is_container %}
32 check_command check_disk!20%!10%!/40 check_command check_disk!20%!10%!/
33{%- else %}41{%- else %}
34 check_command check_all_disks!20%!10%42 check_command check_all_disks_no_squashfs!20%!10%
35{%- endif %}43{%- endif %}
36 }44 }
3745

Subscribers

People subscribed via source and target branches