Thruk External Agent Charm

Code review comment for ~xavpaice/charm-thruk-external-agent:feature/max_check_attempts

  1. Git
  2. lp:~xavpaice/charm-thruk-external-agent
  3. feature/max_check_attempts
  4. Merge into master
Revision history for this message
Xav Paice (xavpaice) wrote :

> Hey,
>
> similarly to the comment on https://code.launchpad.net/~xavpaice/charm-
> graylog/+git/graylog-charm/+merge/397950 --
>
> in general lgtm, but I believe charmhelpers.contrib.charmsupport.nrpe
> currently don't set a default (also cf. https://github.com/juju/charm-
> helpers/issues/564 ).
>
> We'd need to handle defaults either here or in charmhelpers.
>
> Personally I'd lean (explicit is better than implicit) to configure an
> explicit default=4 and make it type=int for the max_check_attempts in
> config.yaml but either here or in charmhelpers works

Worth checking the pattern with NTP, what we have done there is the same as here, the Nagios charm itself doesn't set the parameter at all if it's not listed and therefore uses the default in the service definition template.

« Back to merge proposal