Prometheus Blackbox Exporter Charm

Code review comment for ~xavpaice/charm-prometheus-blackbox-exporter:dev/q2-20

  1. Git
  2. lp:~xavpaice/charm-prometheus-blackbox-exporter
  3. dev/q2-20
  4. Merge into master
Revision history for this message
Paul Goins (vultaire) wrote :

Overall, this looks good.

I have a few comments, the most important likely being about the license, which I think requires attention. The others are things I think should be fixed but aren't really that important.

review: Needs Fixing

« Back to merge proposal