charm-openstack-service-checks

Code review comment for ~xavpaice/charm-openstack-service-checks/+git/charm-openstack-service-checks:ssl-nagios-checks

  1. Git
  2. lp:~xavpaice/charm-openstack-service-checks/+git/charm-openstack-service-checks
  3. ssl-nagios-checks
  4. Merge into master
Revision history for this message
Peter Sabaini (peter-sabaini) wrote :

Comments inline -- one tox.ini issue and some nitpickings

A more general suggestion would be to add some logging to the charm and the service checks to aid in troubleshooting (charm currently has little logging and service checks none). Service checks could maybe just use a syslog handler

review: Needs Fixing

« Back to merge proposal