~xavpaice/charm-nrpe:relation-assertion

Branch merges

Propose for merging

Merged into ~nrpe-charmers/charm-nrpe:master at revision f7aa963d1db76f24bd1f534989494cb5997bdbc0

James Troup (community): Approve on 2020-07-30

Xav Paice (community): Needs Resubmitting on 2020-07-30

Drew Freiberger (community): Needs Fixing on 2020-07-29

Canonical IS Reviewers: Pending requested 2020-07-26

Adam Dyess: Pending requested 2020-07-26

Diff: 58 lines (+18/-3)

3 files modified

Makefile (+1/-1)
hooks/nrpe_utils.py (+11/-1)
hooks/services.py (+6/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

f8a97ed... by Xav Paice on 2020-07-30

Add support for empty nagios_master config

The default setting for nagios_master is "None" (string). This adds
support for that to be the empty string and the (unlikely) event that
it's set to None.

700e56d... by Xav Paice on 2020-07-26

Update wording for lack of Nagios config

524182c... by Brett Milford on 2020-07-24

Modified the function name for clarity.

5c7bda2... by Brett Milford on 2020-07-14

Modified the blocked status message to be complete.

316db7c... by Brett Milford on 2020-07-10

Sets the status to block when missing nagios config.

When setting the status this checks for either the presence
of the nagios_master config or data in the monitors relation.

LP: #1887106

c31ece3... by Xav Paice on 2020-07-28

Add additional checks for LACP bond status

Add checks if the LACPDU port state matches for the underlaying interfaces.

LP: #1877255

Reviewed-on: https://code.launchpad.net/~xavpaice/charm-nrpe/+git/nrpe-charm/+merge/388104
Reviewed-by: Paul Goins <email address hidden>
Reviewed-by: Joe Guo <email address hidden>

5d9c0f7... by Xav Paice on 2020-07-26

Lint and rebase fixes for LACPDU check

16c4760... by Andrea Ieri on 2020-07-24

[trivial] fix check_xfs_errors output typo (CRITCAL -> CRITICAL)

16a49f3... by Giuseppe Petralia on 2020-07-23

Fix linting. I had to disable black check for tests. Black wanted to reformat nrpe_tests converting some line to one line with length > 88 and
then flake8 was complaining as it is configured to check for max line length = 88. I had also disable syntax check for some older variants used in some nagios plugins as I didn't want to update code that has been in use for years with no issues.
I had also to increase flake8 max complexity to 14 because of:

./hooks/nrpe_helpers.py:370:5: C901 'SubordinateCheckDefinitions.__init__' is too complex (14)
./hooks/nrpe_utils.py:193:5: C901 'TolerantPortManagerCallback.__call__' is too complex (11)
./files/plugins/check_netlinks.py:26:1: C901 'check_iface' is too complex (13)

Reviewed-on: https://code.launchpad.net/~peppepetra86/charm-nrpe/+git/charm-nrpe/+merge/387825
Reviewed-by: Paul Goins <email address hidden>

14df450... by Giuseppe Petralia on 2020-07-23

Merge splitted string and fix some wrong indented lines