Code review comment for ~xavpaice/charm-nrpe:bug/1824882

Revision history for this message
Alvaro Uria (aluria) wrote :

I've suggested a few changes for readability, completeness (verify all read-only fs that are not excluded instead of returning the first one found), and a doubt about the input validation (match substrings could induce to errors, should we look for "start of string"?).

review: Needs Fixing

« Back to merge proposal