Code review comment for ~xavpaice/charm-nrpe:nrpe-address

the limitation is that an openstack instance doesn't have any idea at all of it's floating IP address - only the cloud provider can tell Juju that - but the instance is what provides the list of addresses for the relation to Nagios. In this case, what's happening is that somehow the floating IP address of the Nagios unit is getting pumped into the relation data across the cross model relation, but not the floating IP of the nrpe unit - and that means the wrong address is added to nrpe.cfg. It should be fixable, I just am at a bit of a loss as to how right now.

Meantime, this change would allow us to have a non-related Nagios allowed for checks in addition to any related units - that might be handy for the future.

I've not checked if the change of nagios_address_type from private to public needs the relation removing and re-adding to trigger any change. Also, we might be able to use nagios_master rather than add a new config option.

There's a fork for this at cs:~xavpaice/nrpe at this point in time, to allow the site affected to be monitored.