NRPE Charm

Code review comment for ~xavpaice/charm-nrpe:arp_cache

  1. Git
  2. lp:~xavpaice/charm-nrpe
  3. arp_cache
  4. Merge into master
Revision history for this message
Joel Sing (jsing) wrote :

LGTM for standards/readability, however please see comments inline.

It would also be good to see test coverage for at least the new code/script being added.

review: Approve (+1)

« Back to merge proposal