Code review comment for ~xavpaice/charm-logrotated:bug_1833722

Revision history for this message
Paul Goins (vultaire) wrote :

> The change looks good. However, I think actions.py should call
> #!/usr/local/sbin/charm-env python3 so the active_venv() part is automatically
> done and "lib" is also included by default.
>
> Other than that, +1

Good point btw; I wasn't aware of that methodology.

« Back to merge proposal