Code review comment for lp:~xavi-garcia-mena/keeper/task-state-manager

Revision history for this message
Michi Henning (michihenning) wrote :

> Michi,
>
> Yes, I think you're misunderstanding. What I'm saying is because we're using
> `delete o' instead of `o.deleteLater()' in the QLocalSocket's shared_ptr,
> we're setting up a case where it can be destroyed in the middle of its
> bytesWritten signal.

Ah, OK, thanks for the explanation, I get it now :-)

I've pushed a fix and added it to silo 60. The QLocalSocket shared pointers that are handed to the client now have a custom deleter that calls socket->deleteLater().

« Back to merge proposal