Keeper

Code review comment for lp:~xavi-garcia-mena/keeper/task-state-manager

  1. task-state-manager
  2. Merge into devel
Revision history for this message
Xavi Garcia (xavi-garcia-mena) wrote :

Thanks for the review, Charles, I left some comments inline.

I also found a bug in the state management while creating the new integration tests and I will fix them in this branch.

Regarding the QLocalSocket issue... I will change the code to reset the shared_ptr and when I get more information I will let you all know.

Reply

« Back to merge proposal