Code review comment for lp:~xavi-garcia-mena/keeper/task-state-manager

Revision history for this message
Michi Henning (michihenning) wrote :

Thanks for the comments Charles!

I'm a Qt newbie, so I might be getting this wrong. But I was under the impression that, if the QLocalSocket is destroyed, the signal connection is torn down too. In other words, you either get the signal and, if you do, the socket is still guaranteed to be there, or the socket was destroyed, in which case you don't get the signal.

Have I got this wrong?

At any rate, as long as you keep a copy of the socket shared_ptr around, you know that it can't magically disappear from underneath you. Isn't that sufficient to make sure that things are OK with respect to life cycle?

« Back to merge proposal