Code review comment for lp:~xavi-garcia-mena/indicator-sound/restart-dbus-error

Revision history for this message
Lars Karlitski (larsu) wrote :

> the process exists itself, no other process sends SIGTERM.
> It just stops the loop and exists.

Ah sorry I misread the patch as adding those lines to the sigterm handler. Where does the warning about g_object_unref() come from then, though?

> I saw upstart tries to respawn, but only 3 times. After 3 times the result is
> a phone with no sound indicator.

You can change that (and the timing) in the upstart conf file `data/indicator-sound.conf.in`. (I can't believe I'm suggesting that you do this though ;) )

Please talk to Pete about how they fixed the issue in upstart. Seems other projects have this problem as well. I don't see how it makes sense to fix this only here.

« Back to merge proposal