Code review comment for lp:~xavi-garcia-mena/indicator-sound/restart-dbus-error

Revision history for this message
Lars Karlitski (larsu) wrote :

Even if you wanted to merge this, I don't see how this patch fixes any problem.

If the connection is really not there (which I highly doubt, but might be something related to what Pete was saying in the linked bug), indicator-sound should simply exit, because the on_name_lost() callback is called in that case with a NULL connection. I just verified that it does this by unsetting DBUS_SESSION_BUSA_ADRESS. Upstart should automatically respawn the process after some time.

Do you know who sends the SIGTERM to the process?

What's the stack trace of the critical that is pasted in the linked bug (run it with G_DEBUG=fatal-criticals)?

« Back to merge proposal