Code review comment for lp:~xavi-garcia-mena/go-unityscopes/go-subsearch

Revision history for this message
Xavi Garcia (xavi-garcia-mena) wrote :

Thanks for the review Kyle!

There is no reason to not use const & in the parameters, so I've add it :).

Regarding making the members private I didn't add it because that's a class in a cpp file that cannot be accessed from anywhere but that file.

I've added the private as it doesn't harm ;).

« Back to merge proposal