go-unityscopes

Code review comment for lp:~xavi-garcia-mena/go-unityscopes/go-subsearch

  1. go-subsearch
  2. Merge into v2
Revision history for this message
James Henstridge (jamesh) wrote :

I've left some inline comments. The main conceptual problem I see is tying the Subsearch API to the ScopeBase class, with other issues stemming from that (e.g. the WaitGroup on ScopeBase).

review: Needs Fixing
Reply

« Back to merge proposal