Merge lp:~xapantu/wingpanel-indicator-power/trunk into lp:~wingpanel-devs/wingpanel-indicator-power/trunk

Proposed by xapantu
Status: Merged
Approved by: Marcus Wichelmann
Approved revision: 56
Merged at revision: 56
Proposed branch: lp:~xapantu/wingpanel-indicator-power/trunk
Merge into: lp:~wingpanel-devs/wingpanel-indicator-power/trunk
Diff against target: 29 lines (+2/-4)
2 files modified
src/Services/DBusInterfaces/Device.vala (+1/-3)
src/Services/Device.vala (+1/-1)
To merge this branch: bzr merge lp:~xapantu/wingpanel-indicator-power/trunk
Reviewer Review Type Date Requested Status
Marcus Wichelmann (community) testing Approve
Review via email: mp+263941@code.launchpad.net

Commit message

Use a standard g_properties_changed in the dbus device

Description of the change

Use a standard g_properties_changed in the dbus device. At least it is working in newer upower releases.

The current indicator was not working with upower 0.99.3 on Archlinux.

To post a comment you must log in.
Revision history for this message
Marcus Wichelmann (l-admin-3) :
review: Approve (code style)
Revision history for this message
Marcus Wichelmann (l-admin-3) wrote :

Just works! :)

review: Approve (testing)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/Services/DBusInterfaces/Device.vala'
--- src/Services/DBusInterfaces/Device.vala 2015-05-23 21:10:50 +0000
+++ src/Services/DBusInterfaces/Device.vala 2015-07-06 17:16:00 +0000
@@ -34,11 +34,9 @@
34 }34 }
3535
36 [DBus (name = "org.freedesktop.UPower.Device")]36 [DBus (name = "org.freedesktop.UPower.Device")]
37 public interface Device : Object {37 public interface Device : DBusProxy {
38 public abstract HistoryDataPoint[] GetHistory (string type, uint32 timespan, uint32 resolution) throws IOError;38 public abstract HistoryDataPoint[] GetHistory (string type, uint32 timespan, uint32 resolution) throws IOError;
39 public abstract StatisticsDataPoint[] GetStatistics (string type) throws IOError;39 public abstract StatisticsDataPoint[] GetStatistics (string type) throws IOError;
40 public abstract void Refresh () throws IOError;40 public abstract void Refresh () throws IOError;
41
42 public signal void Changed ();
43 }41 }
44}42}
4543
=== modified file 'src/Services/Device.vala'
--- src/Services/Device.vala 2015-06-12 16:40:50 +0000
+++ src/Services/Device.vala 2015-07-06 17:16:00 +0000
@@ -103,7 +103,7 @@
103 }103 }
104104
105 private void connect_signals () {105 private void connect_signals () {
106 device.Changed.connect (update_properties);106 device.g_properties_changed.connect (update_properties);
107 }107 }
108108
109 private void update_properties () {109 private void update_properties () {

Subscribers

People subscribed via source and target branches

to all changes: