Merge ~woutervb/charm-nrpe:network into ~nrpe-charmers/charm-nrpe:master

[Wouter van Bommel]

Bond mismatch should not be critical

[🤖 Canonical IS Merge Bot (canonical-is-mergebot)]

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

[Xav Paice (xavpaice)]

LGTM

review: Approve

[🤖 Canonical IS Merge Bot (canonical-is-mergebot)]

Change successfully merged at revision 3e7db367f05f842b2fe14fd3cdf19749eaba0fd8

diff --git a/files/plugins/check_lacp_bond.py b/files/plugins/check_lacp_bond.py
index b28f369..3e39986 100755
--- a/files/plugins/check_lacp_bond.py
+++ b/files/plugins/check_lacp_bond.py
@@ -52,11 +52,12 @@ def check_lacp_bond(iface):
             d_bond[slave] = slave_aggr_value
 
             if slave_aggr_value != bond_aggr_value:
-                msg = 'CRITICAL: aggregator_id mismatch '
+                # If we can report then only 1/2 the bond is down
+                msg = 'WARNING: aggregator_id mismatch '
                 msg += '({0}:{1} - {2}:{3})'
                 msg = msg.format(iface, bond_aggr_value,
                                  slave, slave_aggr_value)
-                raise CriticalError(msg)
+                raise WarnError(msg)
 
     else:
         msg = 'CRITICAL: {} is not a bonding interface'.format(iface)