Code review comment for lp:~wookey/xdeb/xdeb-archfix

On Thu, Oct 07, 2010 at 11:13:39PM -0000, Wookey wrote:

> Can I wrap on a dot or only on spaces? I thought about it but thought
> bin_cache = get_output(['apt-cache', apt_opts, 'show',
> binary]).splitlines()

> was harder to read

> and assumed that
> bin_cache = get_output(['apt-cache', apt_opts, 'show', binary])
> .splitlines()

> probably wouldn't work.

You could write it this way:

  bin_cache = get_output(['apt-cache', apt_opts, 'show', binary]) \
                .splitlines()

> Can python use 2-char indenting instead of 4? That would save a load
> of space.

It can, but I think Loïc will agree with me that any use of 2-char indents
would be rejected. :) 2-char isn't a deep enough indent to let developers
scan the code efficiently when reading.

> > > @@ -771,7 +788,8 @@
> > > # like); we just need to make sure that native imports happen first
> > > # and then that explicit requests happen in command-line order.
> > > build_sequence = [d for d in depends if d not in explicit_requests]
> > > - build_sequence.extend(args)
> > > + for pkg in args:
> > > + build_sequence.append(get_src_name(options, pkg))
> > > else:
> > > try:
> > > build_sequence = tsort.topo_sort(depends)
> >
> > I'd still like to not allow specifying binary packages on the
> > command-line; people using xdeb certainly know the difference IMNSHO

> I thought the whole point about xdeb was to be a helpful tool. If you
> as a user want to cross-build 'foo', why should you have to look up
> the source package that provides foo when the tool can do it for you so
> trivially?

IMHO the point is not that xdeb shouldn't be helpful, but that any such
helpfulness should not have built-in ambiguity - as is the case when trying
to decide whether a package name refers to a source or a binary package.

Regardless, this is a new feature, however small, and subject to the feature
freeze. I think this should be deferred to the next cycle and implemented
cleanly without ambiguous side-effects.

--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer http://www.debian.org/
<email address hidden> <email address hidden>