Code review comment for lp:~wolfer7/wxbanker/bugfix-lp-534923

Revision history for this message
Michael Rooney (mrooney) wrote :

Okay, I merged it into trunk and made a few minor tweaks in r607 just to better document the logic. I also removed the test.py file; the localetests depend on having fr_FR and ru_RU I believe available, but you can also just run a specific suite via: "python -m wxbanker/tests/csvimportertests", for future reference.

Thanks again for the improvement and csv profile! If you are feeling adventurous feel free to take a peek at https://blueprints.launchpad.net/wxbanker/+spec/csv-import-2.0 , which has some low-hanging usability papercuts, but also some improvements that would fix bugs and the general "automatic csv parsing" idea/logic.

review: Approve

« Back to merge proposal