Code review comment for lp:~wlxing/ecryptfs/fix-bug-1678689

Tyler Hicks (tyhicks) wrote :

Hi Jason - Thanks for the fix!

As you know, the code that you're patching breaks "name=value" pairs up into individual parts. The 'i' variable is used to represent the length of the "name" portion of the string.

I don't think it is correct to set i equal to st_len as st_len is the length of the entire "name=value" string. IIUC, simply adding a break would fix the bug.

What was your reasoning for setting i to st_len?

review: Needs Information

« Back to merge proposal