Merge lp:~wistful/unity-launcher-editor/unity-launcher-editor into lp:unity-launcher-editor

[wst]

improve startup time from 40 seconds to 2 seconds

[CSRedRat (csredrat)]

The best optimization!
Profiling process for patch in Russian: http://habrahabr.ru/post/171005/

[Laudeci Oliveira (laudeci)]

Good job.

review: Approve

[CSRedRat (csredrat)]

Created bug: https://bugs.launchpad.net/unity-launcher-editor/+bug/1136713

[CSRedRat (csredrat)]

Code merged. Can approve patch fix in bug?

=== modified file 'unitylaunchereditor/dialogs/app.py'
--- unitylaunchereditor/dialogs/app.py	2011-11-28 17:12:07 +0000
+++ unitylaunchereditor/dialogs/app.py	2013-02-26 21:54:36 +0000
@@ -71,6 +71,8 @@
         #bottom window buttons
         self.__create_bottom_box(main_box)
         
+        self.icon_manager = IconManager()
+        self.pix_missing = self.icon_manager.get_icon(ThemedIcon('image-missing'),32)
         self.__populate()
         self.connect('delete-event', Gtk.main_quit)
         
@@ -198,12 +200,12 @@
         sname = info['Name']
         desc = info['Comment']
         icon = info['Icon']
-        pix = IconManager().get_icon(ThemedIcon('image-missing'),32)
+        pix = self.pix_missing
         if icon:
             if icon.rfind('.') != -1:
-                pix = IconManager().get_icon(FileIcon(File(icon)),32)
+                pix = self.icon_manager.get_icon(FileIcon(File(icon)),32)
             else:
-                pix = IconManager().get_icon(ThemedIcon(icon),32)
+                pix = self.icon_manager.get_icon(ThemedIcon(icon),32)
         data = (pix, '%s' % sname, obj, sname.upper(), file_path)
         
         return self.launcher_view.add_row(data,True)
@@ -215,12 +217,12 @@
             sname = obj.get('Name',locale=LOCALE)
             desc = obj.get('Comment',locale=LOCALE)
             icon = obj.get('Icon')
-            pix = IconManager().get_icon(ThemedIcon('image-missing'),32)
+            pix = self.pix_missing
             if icon:
                 if icon.rfind('.') != -1:
-                    pix = IconManager().get_icon(FileIcon(File(icon)),32)
+                    pix = self.icon_manager.get_icon(FileIcon(File(icon)),32)
                 else:
-                    pix = IconManager().get_icon(ThemedIcon(icon),32)
+                    pix = self.icon_manager.get_icon(ThemedIcon(icon),32)
             
                 data = (pix, '%s' % sname, obj, sname.upper(), file_path)
             return self.launcher_view.add_row(data,selected)
@@ -325,12 +327,12 @@
                     self.launcher_view.set_value(obj['Name'], self.launcher_view.COLUMN_NAME)
                     self.launcher_view.set_value(obj['Name'].upper(), self.launcher_view.COLUMN_NAME_UPPER)
                     icon = obj['Icon']
-                    pix = IconManager().get_icon(ThemedIcon('image-missing'),32)
+                    pix = self.pix_missing
                     if icon:
                         if icon.rfind('.') != -1:
-                            pix = IconManager().get_icon(FileIcon(File(icon)),32)
+                            pix = self.icon_manager.get_icon(FileIcon(File(icon)),32)
                         else:
-                            pix = IconManager().get_icon(ThemedIcon(icon),32)
+                            pix = self.icon_manager.get_icon(ThemedIcon(icon),32)
                         self.launcher_view.set_value(pix, self.launcher_view.COLUMN_ICON)
                         
         if button_type == TOOLBUTTON_REMOVE: