Code review comment for ~williamhsu/plainbox-provider-checkbox/+git/plainbox-provide-checkbox:bug/lp-1884235/exchanged-the-sequence-of-graphics-log-parsing

Revision history for this message
Pierre Equoy (pieq) wrote :

One comment inline.

Also, why do you have this output:

    ['gdm', 'u']

when running the script with NV modeset enabled?

This looks like a Python side-effect and should be avoided. (sorry I didn't catch that earlier)

review: Needs Fixing

« Back to merge proposal