Code review comment for ~williamhsu/plainbox-provider-checkbox/+git/plainbox-provide-checkbox:bug/lp-1884235/exchanged-the-sequence-of-graphics-log-parsing

Revision history for this message
William Hsu (williamhsu) wrote :

> LGTM, if you did verified it on Sutton/Stella.

Yes, I have verified the patch on a UMA SKU and Sutton platform. The results are as follows.

## NV modeset enabled ##
u@u-ThinkStationP520c:~/workspace$ ./graphics_driver.py
['gdm', 'u']
------------- VIDEO DRIVER INFORMATION -------------
Video Driver: nvidia
Driver Version: 440.64

------------- HYBRID GRAPHICS CHECK ----------------
Graphics Chipset: NVIDIA (10de:1cb6)
Loaded DDX Drivers: nouveau, modesetting, fbdev, vesa
Hybrid Graphics: no

## NV modeset disabled (UMA) ##
whsu@thinkpad-x:~/Workspace/plainbox-provider-checkbox/bin$ ./graphics_driver.py
------------- VIDEO DRIVER INFORMATION -------------
Video Driver: modesetting
Driver Version: 1.20.5

------------- HYBRID GRAPHICS CHECK ----------------
Graphics Chipset: Intel (8086:0a16)
Loaded DDX Drivers: modesetting, fbdev, vesa
Hybrid Graphics: no

« Back to merge proposal