Code review comment for ~williamhsu/plainbox-provider-checkbox/+git/plainbox-provide-checkbox:bug/lp-1884235/exchanged-the-sequence-of-graphics-log-parsing

Revision history for this message
William Hsu (williamhsu) wrote :

@Hugh and Jeremy, the latest change has been verified. May I have a few minutes of your time to do a double-check? Thank you! :)

####################### Validate the change on stock Ubuntu #######################
whsu@thinkpad-x:~/Workspace/plainbox-provider-checkbox/bin$ ./graphics_driver.py
------------- VIDEO DRIVER INFORMATION -------------
Video Driver: modesetting
Driver Version: 1.20.5

------------- HYBRID GRAPHICS CHECK ----------------
Graphics Chipset: Intel (8086:0a16)
Loaded DDX Drivers: modesetting, fbdev, vesa
Hybrid Graphics: no

################# Validate the change on OEM build with NV modeset=Y #################
u@u-ThinkStationP520c:~/Workspace/plainbox-provider-checkbox/bin$ ./graphics_driver.py
['gdm']
------------- VIDEO DRIVER INFORMATION -------------
Video Driver: nvidia
Driver Version: 440.64

------------- HYBRID GRAPHICS CHECK ----------------
Graphics Chipset: NVIDIA (10de:1cb6)
Loaded DDX Drivers: nouveau, modesetting, fbdev, vesa
Hybrid Graphics: no
u@u-ThinkStationP520c:~/Workspace$ sudo cat /sys/module/nvidia_drm/parameters/modeset
Y

################# Validate the change on OEM build with NV modeset=N #################

u@u-ThinkStationP520c:~/Workspace/plainbox-provider-checkbox/bin$ ./graphics_driver.py
['root', 'root']
------------- VIDEO DRIVER INFORMATION -------------
Video Driver: nvidia
Driver Version: 440.64

------------- HYBRID GRAPHICS CHECK ----------------
Graphics Chipset: NVIDIA (10de:1cb6)
Loaded DDX Drivers: nouveau, modesetting, fbdev, vesa
Hybrid Graphics: no
u@u-ThinkStationP520c:~/Workspace$ sudo cat /sys/module/nvidia_drm/parameters/modeset
N

« Back to merge proposal